Skip to content

docs(npm): correct trusted-publishing guidance (it works via the reusable workflow) #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jleni merged 2 commits into from
Jun 20, 2026
Merged

docs(npm): correct trusted-publishing guidance (it works via the reusable workflow) #104

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1899f87
docs(npm): correct trusted-publishing guidance — it DOES work via reu…
jleni Jun 20, 2026
b151bf3
docs(npm): align trusted-publisher guidance with npm's documented beh…
jleni Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions .github/workflows/_publish-npm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,19 @@
name: Reusable Publish NPM

# ⚠️ npm OIDC Trusted Publishing does NOT work through this reusable workflow.
# npm validates the OIDC `job_workflow_ref` claim, which for a reusable workflow
# is THIS file (zondax/_workflows/.github/workflows/_publish-npm.yaml) — not the
# caller's workflow. A package's Trusted Publisher can only name one repo +
# workflow (e.g. Zondax/cli + publish-npm.yaml), so a publish performed here can
# never match it and npm returns `E404 ... is not in this registry`.
# (Verified: @zondax/cli only published once its publish ran in its OWN workflow.)
# npm OIDC Trusted Publishing works through this reusable workflow (e.g.
# @zondax/ledger-casper-js publishes via @v7 with OIDC, no token).
#
# To publish to npm with OIDC, run `npm publish` in the package repo's own
# workflow (see Zondax/cli/.github/workflows/publish-npm.yaml). This workflow is
# still usable for token-based publishing if a token is wired in.
# SETUP (one-time per package, on npmjs.com -> package -> Settings -> Trusted Publisher):
# Organization / Repository: <your package repo, e.g. Zondax/ledger-foo-js>
# Workflow filename: <your CALLER workflow, e.g. publish.yml>
# Grant `id-token: write` on BOTH the caller job and (already set here) this job.
#
# ⚠️ npm documents reusable / workflow_call publishing as finicky: "validation
# checks the CALLING workflow's name instead of the workflow that actually
# contains the publish command, which can cause configuration mismatches."
# If you hit `E404 ... is not in this registry` despite the above, the reliable
# fix is to run `npm publish` in your package's OWN workflow instead — see
# Zondax/cli/.github/workflows/publish-npm.yaml.
# See: https://docs.npmjs.com/trusted-publishers/

on:
Expand Down