[FIX] Added headers to prompt service calls #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Deepak <[email protected]>
Signed-off-by: Deepak <[email protected]>
Deepak-Kesavan
requested review from
harini-venkataraman,
gaya3-zipstack and
pk-zipstack
| if not self.is_public_call: | ||
| headers = {"Authorization": f"Bearer {self.bearer_token}"} | ||
| default_headers = {"Authorization": f"Bearer {self.bearer_token}"} |
There was a problem hiding this comment.
Suggested change
| default_headers = {"Authorization": f"Bearer {self.bearer_token}"} | |
| headers.update({"Authorization": f"Bearer {self.bearer_token}"}) |
|
|
||
| def _post_call( | ||
| self, | ||
| url_path: str, | ||
| payload: dict[str, Any], | ||
| params: Optional[dict[str, str]] = None, | ||
| headers: Optional[dict[str, str]] = None, |
There was a problem hiding this comment.
Suggested change
| headers: Optional[dict[str, str]] = None, | |
| headers: dict[str, str] = {}, |
There was a problem hiding this comment.
@chandrasekharan-zipstack Changing this will create a sonar issue sonarqube(python:S5717)
There was a problem hiding this comment.
@Deepak-Kesavan can you elaborate on the issue? Anyway my main idea was to avoid creating the default_headers dict in the function below and instead to attempt using the same headers arg to carry out the steps. Do you think that will be possible?
| @@ -94,13 +109,19 @@ def _post_call( | |||
| "status_code": 500, | |||
| } | |||
| url: str = f"{self.base_url}/{url_path}" | |||
| headers: dict[str, str] = {} | |||
|
|
|||
| default_headers = {} | |||
There was a problem hiding this comment.
Suggested change
| default_headers = {} |
Comment on lines
+118
to
+119
| if headers: | ||
| default_headers.update(headers) |
There was a problem hiding this comment.
Suggested change
| if headers: | |
| default_headers.update(headers) |
| response: Response = Response() | ||
| try: | ||
| response = requests.post( | ||
| url=url, json=payload, params=params, headers=headers | ||
| url=url, json=payload, params=params, headers=default_headers |
There was a problem hiding this comment.
Suggested change
| url=url, json=payload, params=params, headers=default_headers | |
| url=url, json=payload, params=params, headers=headers |
|
@chandrasekharan-zipstack Keeping the code as it is because it violates a sonar rule. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
How
...
Relevant Docs
Related Issues or PRs
Dependencies Versions / Env Variables
Notes on Testing
...
Screenshots
...
Checklist
I have read and understood the Contribution Guidelines.