Images/Icons folder restored to fix compilation bug#229
Open
bazonkey wants to merge 3 commits intoZerbu:masterfrom
Open
Images/Icons folder restored to fix compilation bug#229bazonkey wants to merge 3 commits intoZerbu:masterfrom
bazonkey wants to merge 3 commits intoZerbu:masterfrom
Conversation
…ged build action to "content" for all images.
Added /Images folder to Constructor5.UI. Set all images build action as 'Content' and Copy to Output Directory as 'copy if newer'. Fixes refusal to compile issue caused by /Images/Background.png not being found in /bin.
Added /Icons folder. Changed resource type to Content and build action to 'Copy if newer'. This prevents crashing that occurs when trying to select an icon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: when downloading the source code to compile on VS, the application refuses to compile.
Located issue: Images required for the application to work are not included in the source code. When the application attempts to run, it cannot find image files(like Images/Background.png or the icon files). They are meant to populate in /bin, but are not found there.
Fix: /Images and /Icons were added to Constructor5.UI.csproj and set to build action: 'Content', as well as copy action to 'Copy if newer'. /Images is removed from .gitignore(for some reason, images were ignored but icons were not).
Related: #187 removes /Images from .gitignore and updated installation instructions for fixing this issue manually. This PR includes the image files and allows the program to compile normally.