Skip to content

Commit

Permalink
fix: misc Button implementations not using isIconButton prop (appsmit…
Browse files Browse the repository at this point in the history
…horg#37382)

## Description

Fixes issues introduced when we added min width for buttons in appsmithorg#37367


## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]
> 🟣 🟣 🟣 Your tests are running.
> Tests running at:
<https://github.com/appsmithorg/appsmith/actions/runs/11831136814>
> Commit: dce8dcd
> Workflow: `PR Automation test suite`
> Tags: `@tag.Sanity`
> Spec: ``
> <hr>Thu, 14 Nov 2024 05:12:11 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
  • Loading branch information
hetunandu authored Nov 14, 2024
1 parent 07f20ea commit ca1ed1a
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ function CodeBlock({ code }: CodeBlockProps) {
}}
>
<Code>{code}</Code>
<Button kind="tertiary" startIcon="copy-control" />
<Button isIconButton kind="tertiary" startIcon="copy-control" />
</Wrapper>
);
}
Expand Down
1 change: 1 addition & 0 deletions src/components/editorComponents/CodeEditor/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -1710,6 +1710,7 @@ class CodeEditor extends Component<Props, State> {
"commands-button invisible",
!showSlashCommandButton && "!hidden",
)}
isIconButton
kind="tertiary"
onClick={() => {
const newValue =
Expand Down
2 changes: 2 additions & 0 deletions src/pages/AppViewer/Navigation/TopStacked.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ export function TopStacked(props: NavigationProps) {
{tabsScrollable && (
<ScrollBtnContainer
className="left-0 scroll-arrows"
isIconButton
kind="tertiary"
onMouseDown={() => startScrolling(true)}
onMouseLeave={stopScrolling}
Expand Down Expand Up @@ -153,6 +154,7 @@ export function TopStacked(props: NavigationProps) {
{tabsScrollable && (
<ScrollBtnContainer
className="right-0 scroll-arrows"
isIconButton
kind="tertiary"
onMouseDown={() => startScrolling(false)}
onMouseLeave={stopScrolling}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,12 @@ export default function HelpDropdown(props: DebuggerLog) {
return (
<Popover>
<PopoverTrigger>
<Button kind="tertiary" size="sm" startIcon="question-line" />
<Button
isIconButton
kind="tertiary"
size="sm"
startIcon="question-line"
/>
</PopoverTrigger>
<PopoverContent className={styles.consoleItemHelpContent}>
<List
Expand Down

0 comments on commit ca1ed1a

Please sign in to comment.