Make git submodules use HTTPS instead of SSH link, also fix building on Linux#10
Conversation
|
This can't be merged as-is. Changing the submodule to use https instead of ssh is fine, but that linker version script controls symbol visibility for the resulting shared object, so it's important. If it's failing to build, then you probably have a toolchain issue. What's your build setup? |
|
Well my CMake version is 4.2.2, using the Kitware apt repos for it, and I'm running Debian 13 on the build machine. I checked and the tmj.sym file is in the src folder. Here is my CMakeLists.txt that I am using for this, I have mostly just used the example from the readme for running this. And the errors from the linker when using this option |
|
Actually, I changed that line to use this, and now it builds just fine, I added the |
|
Squash your commits and I'll merge this. |
|
Gotta fix up the commit message body as well, you can just delete it and leave the summary line. |
This fixes an issue I was having when attempting to use this with FetchContent in CMake.
For some reason, it was set to use an SSH link for cloning the Unity tests instead of HTTPS, so I have changed the link.
With this change, you will no longer get a SSH error when trying to clone with the submodules.
Also, I fixed building this project on Linux by disabling this line in the CMakeLists.txt
target_link_options(tmj PRIVATE "LINKER:--version-script=src/tmj.sym")I'm not exactly sure if that is needed or what this option does honestly.