Skip to content

fix(assessment): clarify severity and preflight result guidance - #45

Merged
ai-coding-guardrails[bot] merged 4 commits into
mainfrom
fix/assessment-guidance
Oct 20, 2026
Merged

ai-coding-guardrails[bot] merged 4 commits into
mainfrom
fix/assessment-guidance

Conversation

@JonZeolla

@JonZeolla JonZeolla commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

The assessment template told authors to omit severity, although the renderer reads that field and the bundle metadata counts it. A fresh Fast assessment produced zero metadata findings until the author restored severity. Make the instructions match the existing renderer contract: severity is explicit; likelihood, impact, and their matrix buckets are derived.

Rename two setup preflight result labels so the agent does not mistake them for CLI commands. The underlying commands are unchanged.

Validation: documentation and comments only. No local tests run; CI validates this change.

PR Description from Zenable

Fixes the assessment template instructions, which told authors to omit severity even though the renderer reads it and bundle metadata counts it. Also renames two setup preflight result labels so the agent doesn't mistake them for CLI commands.

  • Template comments in data.js now state that severity is explicit, while likelihood, impact, and matrix buckets are derived.
  • Two preflight result labels in the setup SKILL.md are renamed; the underlying commands are unchanged.

Documentation and comments only; no local tests run.

@ai-coding-guardrails-jon-sandbox ai-coding-guardrails-jon-sandbox Bot added the zenable/risk:low Zenable assessed this PR as LOW risk. label Oct 19, 2026
Comment thread plugins/z/skills/setup/SKILL.md Outdated
@JonZeolla
JonZeolla marked this pull request as ready for review October 20, 2026 14:09
@JonZeolla
JonZeolla enabled auto-merge (squash) October 20, 2026 14:09

@ai-coding-guardrails ai-coding-guardrails Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 😎

I didn't find anything of concern

Risk: 🟢 Low

Did you know Zenable also supports GitLab SaaS and self-managed?

@ai-coding-guardrails
ai-coding-guardrails Bot merged commit 3b45e9e into main Oct 20, 2026
7 checks passed
@ai-coding-guardrails

Copy link
Copy Markdown

Merged by Zenable: assessed low risk at 96c75b4; merge initiated by @JonZeolla via auto-merge. Human review was waived by your merge-gate policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

zenable/risk:low Zenable assessed this PR as LOW risk.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant