Have ci check #[cfg(fuzzing)] code for errors#23
Open
Techcable wants to merge 1 commit into
Open
Conversation
Type checks the #[cfg(fuzzing)] code without actually running cargo-fuzz or needing a nightly toolchain. Ordinary cargo check/clippy/test never set that cfg, so type errors would go unnoticed until fuzz.yml CI tier, which only runs on a daily schedule. Also adds a fuzz-check task to the Justfile, which is run as part of the 'check' and 'ci' jobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Before this commit, problems with
#[cfg(fuzzing)]cod would go unnoticed until fuzz.yml CI tier,which only runs on a daily schedule.
This adds a CI job to type check the #[cfg(fuzzing)] code without
actually running cargo-fuzz or needing a nightly toolchain.
It also adds a similar job to the Justfile that checks the same thing.
Checklist
cargo fmt --allcargo clippy --all-targets --all-features -- -D warningsis cleancargo testpasses (andcargo test --all-features -- --ignoredif youtouched spawn / containment / streaming paths)
CHANGELOG.md[Unreleased]updated when the change is user-facing(
Added/Changed/Fixed)docs/guide set) if behavior or API changedCargo.toml(seeCONTRIBUTING.md)Notes for reviewers
I came across this while working on PR #22