-
-
Notifications
You must be signed in to change notification settings - Fork 39
Add Windows support #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Gaweringo
wants to merge
17
commits into
Zeioth:main
Choose a base branch
from
Gaweringo:windows-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for taking the time to send this PR @Gaweringo. I imagine some Windows users might prefer this approach over WSL, specially when trying the plugin for the first time. Please give me this week to review it. In the mean time if you want, you can check if the tests pass on windows running this command inside of Neovim:
|
I ran the test files for the languages I changed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would make all commands which use
rm -f
andmkdir -p
windows compatible by adding theget_commands()
function toutils
which swaps the unix commands with the cmd commandserase /s /q
andmkdir
.The way to ignore errors is also different and is changed from
|| true
to> nul 2> nul & cd.
for cmd. Ignoring errors is also needed formkdir
in cmd, since there is no-p
equivalent.I could not test the
asm
changes fully yet, since it uses linux/unix syscalls from what I understand. Building and linking works, but the "Run program" does not succeed and exits with a large negative exit code.Languages which had changes:
Bau which had changes:
From my testing, everything should still work on Linux with these changes.
Let me know if I need to change something, or if this PR might go in the wrong direction / uses an undesired approach.