This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
update dask-ml to v1.0.0 #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zexuan-zhou
commented
Aug 14, 2019
dask_ml/model_selection/_search.py
Outdated
| @@ -120,7 +134,68 @@ def build_graph( | |||
| cache_cv=True, | |||
| multimetric=False, | |||
| ): | |||
| # This is provided for compatibility with TPOT. Remove | |||
| # once TPOT is updated and requires a dask-ml>=0.13.0 | |||
| def decompress_params(fields, params): | |||
There was a problem hiding this comment.
This corresponds to gathering cv results as they finished:
dask#433
zexuan-zhou
commented
Aug 14, 2019
dask_ml/model_selection/_search.py
Outdated
| @@ -1219,21 +1267,59 @@ def fit(self, X, y=None, groups=None, **fit_params): | |||
| if scheduler is dask.threaded.get and n_jobs == 1: | |||
| scheduler = dask.local.get_sync | |||
|
|
|||
| out = scheduler(dsk, keys, num_workers=n_jobs) | |||
| if "Client" in type(getattr(scheduler, "__self__", None)).__name__: | |||
zexuan-zhou
commented
Aug 14, 2019
| feature_union, | ||
| feature_union_concat, | ||
| fit, | ||
| fit_and_score, | ||
| fit_best, | ||
| fit_transform, | ||
| get_best_params, | ||
| pipeline, | ||
| score, | ||
| _get_fold_sample_weights, |
There was a problem hiding this comment.
Ryan's fix is there and unchanged
zexuan-zhou
commented
Aug 14, 2019
| feature_union, | ||
| feature_union_concat, | ||
| fit, | ||
| fit_and_score, | ||
| fit_best, | ||
| fit_transform, | ||
| get_best_params, | ||
| pipeline, | ||
| score, | ||
| _get_fold_sample_weights, | ||
| get_sample_weights |
There was a problem hiding this comment.
Ryan's fix is there and unchanged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.