Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SetBloodColor #2922

Closed
wants to merge 3 commits into from
Closed

Added SetBloodColor #2922

wants to merge 3 commits into from

Conversation

Boondorl
Copy link
Contributor

@Boondorl Boondorl commented Jan 30, 2025

Allows for Actor blood colors to be changed on the fly instead of needing to use dummy Actor classes to create translations. Serializing has been improved such that anything with a blood translation will simply recreate it on load (including for decals).

This fails to serialize properly regardless so simply recreate it at load time.
@Boondorl Boondorl marked this pull request as draft January 30, 2025 17:46
@MajorCooke
Copy link
Contributor

You and Jay are on fire! Keep up the fantastic work! May this momentum maintain as long as possible!

@Boondorl
Copy link
Contributor Author

Boondorl commented Jan 30, 2025

So originally I started this one with a simple function but then Nash brought to my attention that it actually had been tried in the past and was rejected. Looking through the problems, it seems translations in general have zero proper serializing and basically work off thoughts and prayers. In order for this to be implemented it's likely translations will need to be made fully serializable. I can fix edge cases with blood translations but since some Actors directly use BloodTranslation in their translation field with no attached color to recreate it, this method simply isn't going to work.

The good news is that translations have a proper sorting system which makes which bucket they belong to easy to determine. The bad news is I need to learn how they work well enough to know what actually needs to be written out and how to rebuild it from that info. This will fix translations across the board regardless of things like mod order when loading a save.

@Boondorl
Copy link
Contributor Author

Will need to rework translation serializing first

@Boondorl Boondorl closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants