fix: resolve eslint react-hooks/set-state-in-effect violations

app/assessment/page.tsx

@@ -1,6 +1,6 @@
 "use client";
 
-import React, { useEffect, useState, Suspense } from 'react';
+import React, { useEffect, useState, Suspense, useMemo } from 'react';
 import { useSearchParams, useRouter } from 'next/navigation';
 import { fetchGitHubProfile, UserAssessmentData } from '@/lib/github';
 import { generateAssessment, AssessmentMode, AssessmentResult, compareCandidates, ComparisonCandidate, ComparisonResult } from '@/lib/ai';
@@ -33,7 +33,15 @@ function AssessmentContent() {
   const [compareQuestion, setCompareQuestion] = useState('');
   const [newCompareUser, setNewCompareUser] = useState('');
   const [addingToCompare, setAddingToCompare] = useState(false);
-  const [showCompletenessWarning, setShowCompletenessWarning] = useState(false);
+  const [dismissedWarning, setDismissedWarning] = useState(false);
+  const showCompletenessWarning = useMemo(() => {
+    if (!assessment || dismissedWarning) return false;
+    return !assessment.summary || assessment.summary.length < 20 ||
+      !assessment.detailedReport || assessment.detailedReport.length < 200 ||
+      !assessment.repoAssessments || assessment.repoAssessments.length === 0 ||
+      !assessment.timeline || assessment.timeline.length === 0 ||
+      !assessment.swot.strengths || assessment.swot.strengths.length === 0;
+  }, [assessment, dismissedWarning]);
 
   useEffect(() => {
     if (!username) return;
@@ -47,6 +55,13 @@ function AssessmentContent() {
 
         const aiResponse = await generateAssessment(ghData, settings, mode);
         setAssessment(aiResponse);
+
+        const stored: ComparisonCandidate[] = JSON.parse(sessionStorage.getItem('assessedCandidates') || '[]');
+        const entry: ComparisonCandidate = { username: ghData.username, avatarUrl: ghData.avatarUrl, assessment: aiResponse };
+        const idx = stored.findIndex((c: ComparisonCandidate) => c.username === ghData.username);
+        if (idx >= 0) stored[idx] = entry; else stored.push(entry);
+        try { sessionStorage.setItem('assessedCandidates', JSON.stringify(stored)); } catch {}
+        setSavedCandidates(stored);
 
       } catch (err: any) {
         console.error(err);
@@ -60,30 +75,6 @@ function AssessmentContent() {
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [username, mode, settings.githubToken, settings.aiProvider, settings.apiKey, settings.apiEndpoint, settings.model]);
 
-  useEffect(() => {
-    if (assessment) {
-      const hasMissing = !assessment.summary || assessment.summary.length < 20 ||
-        !assessment.detailedReport || assessment.detailedReport.length < 200 ||
-        !assessment.repoAssessments || assessment.repoAssessments.length === 0 ||
-        !assessment.timeline || assessment.timeline.length === 0 ||
-        !assessment.swot.strengths || assessment.swot.strengths.length === 0;
-      setShowCompletenessWarning(hasMissing);
-    }
-  }, [assessment]);
-
-  useEffect(() => {
-    const stored = JSON.parse(sessionStorage.getItem('assessedCandidates') || '[]');
-    setSavedCandidates(stored);
-
-    if (assessment && githubData) {
-      const entry: ComparisonCandidate = { username: githubData.username, avatarUrl: githubData.avatarUrl, assessment };
-      const idx = stored.findIndex((c: ComparisonCandidate) => c.username === githubData.username);
-      if (idx >= 0) stored[idx] = entry;
-      else stored.push(entry);
-      try { sessionStorage.setItem('assessedCandidates', JSON.stringify(stored)); } catch {}
-      setSavedCandidates([...stored]);
-    }
-  }, [assessment, githubData]);
 
   const handleAskQuestion = async (e: React.FormEvent) => {
     e.preventDefault();
@@ -348,7 +339,7 @@ function AssessmentContent() {
                 <p className="text-xs text-[#C9D1D9] mt-1">For best results, use Gemini 2.5 Flash (1M context) or a model with 32K+ context and high token output limits. <a href="/settings" className="text-[#58A6FF] hover:underline">Adjust settings</a></p>
               </div>
             </div>
-            <button onClick={() => setShowCompletenessWarning(false)} className="p-1 hover:bg-[#E3B341]/20 rounded transition-colors text-[#E3B341]/60 hover:text-[#E3B341]" aria-label="Dismiss warning">
+            <button onClick={() => setDismissedWarning(true)} className="p-1 hover:bg-[#E3B341]/20 rounded transition-colors text-[#E3B341]/60 hover:text-[#E3B341]" aria-label="Dismiss warning">
               <X className="w-4 h-4" aria-hidden="true" />
             </button>
           </div>

app/settings/page.tsx

@@ -1,6 +1,6 @@
 "use client";
 
-import React, { useState, useEffect } from 'react';
+import React, { useState } from 'react';
 import { useRouter } from 'next/navigation';
 import { useStore } from '@/lib/store';
 import { AI_PROVIDERS, AIProvider, PromptSize } from '@/lib/types';
@@ -11,10 +11,6 @@ export default function SettingsPage() {
   const { settings, updateSettings } = useStore();
   const [localSettings, setLocalSettings] = useState(settings);
 
-  useEffect(() => {
-    setLocalSettings(settings);
-  }, [settings]);
-
   const handleProviderChange = (providerId: AIProvider) => {
     const info = AI_PROVIDERS.find(p => p.id === providerId);
     setLocalSettings(prev => ({

hooks/useLoadingMessage.ts

@@ -1,6 +1,6 @@
 "use client";
 
-import { useEffect, useMemo, useRef, useState } from "react";
+import { useEffect, useMemo, useState } from "react";
 
 /**
  * The canonical list of fun "AI is running..." one-liners.
@@ -73,24 +73,19 @@ export function useLoadingMessage(
   messages: readonly string[] = DEFAULT_LOADING_MESSAGES,
   intervalMs = 2200,
 ): string {
-  const [index, setIndex] = useState(0);
-  const shuffled = useMemo(() => shuffle(messages), [messages]);
+  const shuffledOnMount = useMemo(() => shuffle(messages), [messages]);
+  const [state, setState] = useState({ list: shuffledOnMount, idx: 0 });
 
-  // Reset index when the message set changes.
   useEffect(() => {
-    setIndex(0);
-  }, [shuffled]);
-
-  // Handle the rotation interval.
-  useEffect(() => {
-    if (shuffled.length <= 1) return; // nothing to cycle.
-
-    const id = setInterval(() => {
-      setIndex((prev) => (prev + 1) % shuffled.length);
-    }, intervalMs);
-
+    if (shuffledOnMount.length <= 1) return;
+    const id = setInterval(
+      () => setState((s) => ({ list: s.list, idx: (s.idx + 1) % s.list.length })),
+      intervalMs,
+    );
     return () => clearInterval(id);
-  }, [shuffled, intervalMs]);
+  }, [shuffledOnMount, intervalMs]);
 
-  return shuffled[index] ?? shuffled[0] ?? "";
+  const list = state.list === shuffledOnMount ? state.list : shuffledOnMount;
+  const idx = state.list === shuffledOnMount ? state.idx : 0;
+  return list[idx] ?? list[0] ?? "";
 }