Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sign conversion warnings #337

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Fix sign conversion warnings #337

merged 2 commits into from
Jan 28, 2025

Conversation

dacav
Copy link
Contributor

@dacav dacav commented Jan 28, 2025

The -Wsign-conversion warning is currently disabled in pam_u2f, due to a conflicting macro in security/pam_modutil.h (PAM_MODUTIL_DEF_PRIVS). This setting shadowed a couple of warnings, which have been noticed while working on the build system.

@dacav dacav requested a review from LDVG January 28, 2025 13:14
@dacav dacav force-pushed the dacav/sign-conversion branch from 42e549b to 41c8c70 Compare January 28, 2025 13:43
@LDVG LDVG force-pushed the dacav/sign-conversion branch from 41c8c70 to acd5fbd Compare January 28, 2025 15:52
@LDVG LDVG merged commit acd5fbd into main Jan 28, 2025
27 of 28 checks passed
@LDVG LDVG deleted the dacav/sign-conversion branch January 28, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants