test: avoid side effects within assert() call

This fixes a false positive from cppcheck(1): all modules under tests/ have NDEBUG defined
Yubico · Jan 16, 2025 · ecc6213 · ecc6213
1 parent ad11405
commit ecc6213
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/tests/get_devices.c b/tests/get_devices.c
@@ -752,8 +752,10 @@ int main(void) {
   const struct passwd *pwd;
   char *username;
 
-  assert((pwd = getpwuid(geteuid())) != NULL);
-  assert((username = strdup(pwd->pw_name)) != NULL);
+  pwd = getpwuid(geteuid());
+  assert(pwd != NULL);
+  username = strdup(pwd->pw_name);
+  assert(username != NULL);
 
   test_nouserok(username);
   test_ssh_credential(username);