[YP-688] feat : 로그아웃 API 개발 #159
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jira: YP-688
Jira: YP-688
github-actions
bot
added
D-2
05AM
reviewed
May 26, 2025
Comment on lines
+159
to
+177
| /** | ||
| * 쿠키에서 Refresh Token 추출 | ||
| */ | ||
| private String extractRefreshTokenFromCookies(HttpServletRequest request) { | ||
| if (request.getCookies() == null) return ""; | ||
|
|
||
| return Arrays.stream(request.getCookies()) | ||
| .filter(cookie -> REFRESH_TOKEN_COOKIE_NAME.equals(cookie.getName())) | ||
| .map(Cookie::getValue) | ||
| .findFirst() | ||
| .orElse(""); | ||
| } | ||
|
|
||
| /** | ||
| * 토큰 유효성 검사 | ||
| */ | ||
| private boolean isTokenInvalid(String token) { | ||
| return !StringUtils.hasText(token); | ||
| } |
Contributor
There was a problem hiding this comment.
P3: 관련 메서드들이 컨트롤러가 아닌 관련 서비스(ex. RefreshTokenService 등) 에서 구현되어 기능이 분리되면 좋을 것 같습니다!
05AM
reviewed
May 26, 2025
| } | ||
|
|
||
| public void logout(String refreshToken) { | ||
| Long memberId; |
Contributor
There was a problem hiding this comment.
P4: 로그아웃 로직에서 member id를 따로 빼신 이유가 있을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: YP-688
💡 유형
💁 해결하려는 문제를 적어주세요
🤔 어떤 방식으로 해결했는지 적어주세요
🙋 중점적으로 리뷰 했으면 하는 부분이 있다면 적어주세요
🧑🏫 이해를 위해 필요한 자료가 있다면 첨부해주세요