Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to record internal node names when writing tree to newick. #255

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

StephenStaklinski
Copy link

No description provided.

@mattjones315
Copy link
Collaborator

Hi @StephenStaklinski,

Thanks very much for using Cassiopeia and for requesting this PR. It sounds like this will be useful if you want to record all the internal nodes, instead of just the leaf names. This changes to data.utilities.to_newick look good, but you'll also want to add an option to CassiopeiaTree.get_newick to make sure this option is exposed to the user from the CassiopeiaTree API.

Thanks very much again and please let me know if you need any pointers on how to make this last small change.

Best,
Matt

@StephenStaklinski
Copy link
Author

Hi @mattjones315, thanks for pointing this out. Those changes should be made now. Let me know if I missed anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants