-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Code Rendering #36
Conversation
Hi @Yohn, this is the mirror PR of picocss#651. However I'm getting these errors when trying to build it:
|
I believe those errors were the sass errors from the original pico repo, you shouldn't have that issue when building from this fork. Also, I setup a workflow that automatically builds the css directory so no need to run the build command before submitting a pull request here. Thanks for submitting the pull request! It looks like it's passing, I'll check it out more when I get back to my computer. |
This PR is based on your main branch and it is also returning the errors on the main branch.
I can build without any issues on the original Pico repo.
That's pretty cool! Contributors don't need to manually build the files, it is also make code review cleaner. You may also want to put this note to the contributing guidelines. |
Merged correctly. I saw a build thing here in github to build before merging, and I tried that and it failed - but I think its because of the github token being on my account, and not yours. Thats why I'm seeing a red X by this request. After I merged it, the workflow went a built the css files as expected and it worked out correctly. What version of sass do you have installed? I just checked mine and got:
and I see the current version is 1.83.4 so I'll be updating shortly to see if I find the same error messages. And the contributing guidelines. have been updated! Thanks for pointing that out! |
This PR improves the style for block and inline
<code>
tags.Fix Overflow
Commit: 37dac63
Move the
overflow-x: auto;
property frompre
tocode
to fix scrolling and padding.Improve Inline Spacing
Commit: 3946e8f
The inline
<code>
tags touch each other when stacked in multiple lines, so I adjusted the vertical padding to0.125rem
. I also addedvertical-align: middle;
to improve the text alignment.