Open
Conversation
VladPavelescu
added
member: Vlad
status: ready for review
Signed-off-by: VladPavelescu <126763092+VladPavelescu@users.noreply.github.com>
VladPavelescu
force-pushed
the
vp/save_yp_on_exit
branch
from
4cf8f7a to
b39bba5
Compare
src/asmcnc/apps/maintenance_app/widget_maintenance_spindle_settings.py
Outdated
Show resolved
Hide resolved
Signed-off-by: VladPavelescu <126763092+VladPavelescu@users.noreply.github.com>
Masc999
requested changes
Jun 26, 2024
Collaborator
Masc999
left a comment
Masc999
left a comment
There was a problem hiding this comment.
This needs to be a bit more polished. It now always shows the "settings saved" popup. Even if you didn't change anything.
Even worse: save on exit is not implemented on the other tabs:
change brush settings -> quit app : popup says settings have been saved. But they haven't.
Signed-off-by: VladPavelescu <126763092+VladPavelescu@users.noreply.github.com>
Collaborator
|
Now, when a 110V spindle is selected, the 110V info popup always shows when you close maintenance. Even if you don't change anything. Please change it so the popup shows up when a 110V spindle is selected from the dropdown and not on_save. Then it will show directly when the user changes the spindle and not some undefined time later when he closes the app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Save YP profile on exit
Jira Ticket
Changelog (master doc)
On merging your PR, please copy the changelog to the master doc.
Checklist
Description
Screenshots
Dependencies for merge
Testing
Visual Test
Function Test
Unit Tests