Conversation
'q' shows popup to add new widgets
…the screen (screen_tester)
Masc999
added
member: Marc
status: ready for review
Added icon updated help text
| pos: self.parent.pos | ||
| Image: | ||
| source: "./asmcnc/skavaUI/img/go_datum_y.png" | ||
| source: pu.get_path('go_datum_y.png') |
There was a problem hiding this comment.
Would be interested to see whether using get_path so often will cause a performance hit in the future (with existing searches, it's taking 4s on startup on a pi). Suggest we use the Kivy resources functions (see #code-focus) alongside some relative paths (yes, a pain to refactor but much quicker)
There was a problem hiding this comment.
Had this marked as "for later". Had a look at it now and it seems like a good idea to implement.
|
|
||
|
|
||
| @staticmethod | ||
| def screenname_to_filename(name_to_convert, reverse=False): |
There was a problem hiding this comment.
Does it need @staticmethod? could make it into a function instead
| screen = screen_class() | ||
| return screen | ||
| except ImportError as ex: | ||
| Logger.exception(ex) |
There was a problem hiding this comment.
I think Logger.exception should already output the exception traceback, might be worth instead having a hint message inside.
|
|
||
| def screen_name_input_focus(self, instance, state): | ||
| if state: | ||
| InspectorSingleton().disable_key_input() |
There was a problem hiding this comment.
store singleton instead of "creating" twice?
2 participants
ScreenDesigner Alpha v0.1
Checklist
Description
The screen_designer_app is a separate app. It's porpuse is to design screens directly in there without the need of manually writing a builder string or python code.
When saving, useable python code is generated. The just generated file can be loaded directly so any errors will appear instantly.
Handles both kivy and python imports needed by the widgets on the screen.
special comment markers take care of not overwriting "user code" when an existing screen gets modified later on.
Notes
Dependencies for merge
Testing
Visual Test
Function Test
Unit Tests
Screenshots (if applicable)