Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom id_generators and signed hex trace id handling, and make 128bit trace IDs the default #131

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

kawaiwanyelp
Copy link
Contributor

Description

Couple of changes here:

  • Makes the get_trace_id function tolerant of any trace ID set in X-B3-TraceId, as trace IDs are supposed to be immutable. Also makes 128-bit trace IDs the default to be generated.
  • Removes signed hex trace ID handling. No internal trace IDs being generated are ever '0x' or '-0x' prefixed, nor does the B3 spec allow it.
  • Removes the zipkin.trace_id_generator Pyramid setting, as it is only used by YM to make the default trace ID generated the request ID, which doesn't make sense for a trace ID. A newly generated 128-bit trace ID is good enough.

Testing

make test passes

Notes

Following approvals, I'll make a major version bump in master.

@kawaiwanyelp kawaiwanyelp force-pushed the u/kawaiwan/CLIENTOBS-1487-128bit-trace-ids branch from bf81656 to a186ac4 Compare September 24, 2024 15:57
@kawaiwanyelp kawaiwanyelp merged commit 9d8f05b into master Sep 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants