Remove custom id_generators and signed hex trace id handling, and make 128bit trace IDs the default #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Couple of changes here:
get_trace_id
function tolerant of any trace ID set inX-B3-TraceId
, as trace IDs are supposed to be immutable. Also makes 128-bit trace IDs the default to be generated.zipkin.trace_id_generator
Pyramid setting, as it is only used by YM to make the default trace ID generated the request ID, which doesn't make sense for a trace ID. A newly generated 128-bit trace ID is good enough.Testing
make test
passesNotes
Following approvals, I'll make a major version bump in master.