Add --memory option to paasta local-run to allow overriding of memory… #3823
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… limit set in yelpsoa-configs.
In my first attempt at this branch, I tried adding a
memory
argument torun_docker_container
, and havingHowever, the actual docker command has
--mem-swap={instance_config.get_mem() + 64}
(viaformat_docker_parameters
callingget_mem_swap
), and also we sometimes have environment variables that referenceinstance_config.get_mem()
, so just modifyinginstance_config.config_dict["mem"]
seems like a more complete solution.