Have setup_kubernetes_job prioritize services whose git_shas are chan… #3577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfongatyelp
approved these changes
Mar 29, 2023
nemacysts
approved these changes
Mar 29, 2023
jfongatyelp
reviewed
Mar 30, 2023
EvanKrall
force-pushed
the
u/krall/prefer_regular_bounce
branch
from
684760c
to
d5cba35
Compare
jfongatyelp
approved these changes
Mar 31, 2023
paasta_tools/kubernetes_tools.py
Outdated
Comment on lines
230
to
254
| @property | ||
| def deployment_version(self): | ||
| return DeploymentVersion(self.git_sha, self.image_version) | ||
|
|
EvanKrall
force-pushed
the
u/krall/prefer_regular_bounce
branch
from
d5cba35
to
285311f
Compare
nemacysts
approved these changes
Apr 11, 2023
|
This also looks a bit too good/easy to close (conflict is minor). But I wouldn't want to just press merge since someone needs to validate everything is okay after rolling out. |
…_versions are changing, so that real bounces take priority over big bounces.
…sary deployment_version property on Application
EvanKrall
force-pushed
the
u/krall/prefer_regular_bounce
branch
from
285311f
to
05ea9f6
Compare
jfongatyelp
approved these changes
Apr 1, 2024
nemacysts
approved these changes
Apr 1, 2024
Comment on lines
+269
to
+270
| """This will return 1 if the desired deployment_version matches an existing deployment_version, and 0 | ||
| otherwise. This will cause applications that need a new deployment_version to be handled first. |
There was a problem hiding this comment.
on another read: the 0 otherwise bit isn't 100% accurate since we return 2 for broken apps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ging, so that real bounces take priority over big bounces.