throwing a timeout error when the underlying crochet impl raises timeout #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """Error raised when result() is called from HTTPFuture | ||
| and call was actually cancelled | ||
| """ | ||
|
|
||
|
|
||
| class TimeoutError(Exception): |
There was a problem hiding this comment.
Should these base extend a common base exception that is specific to swaggerpy?
It's often nice to be able to catch some general error without worry about catching unrelated things. Maybe this needs a SwaggerRequestError as a base?
There was a problem hiding this comment.
I do like that idea let me add that!
kfreedland
force-pushed
the
throw-timeout-error
branch
from
4bc1799
to
1cc4527
Compare
|
lgtm ... a unit test case which assertRaises this error would be helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.