Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some changes which enabled me to use the PagerDuty swagger #135

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jakedt
Copy link

@jakedt jakedt commented Dec 13, 2016

No description provided.

@coveralls
Copy link

coveralls commented Dec 13, 2016

Coverage Status

Coverage decreased (-0.2%) to 97.295% when pulling 1700898 on jakedt:allof_responses into 2446114 on Yelp:master.

@advance512
Copy link

This is a great contribution, but unfortunately the build fails and tests are missing, decreasing coverage.

@jakedt, would you mind adding proper tests so this can be merged in? It is highly useful.

This is referenced in issue #7.

@sjaensch
Copy link
Contributor

sjaensch commented Feb 2, 2017

@jakedt thanks for your contribution! Would you be able to add a few tests that verify the new behavior? Ignore the py26 test failure for now, I think we'll remove Python 2.6 support real soon now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants