Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for empty val. Merge json correctly #1024

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Add check for empty val. Merge json correctly #1024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tron/serialize/runstate/dynamodb_state_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,11 +165,12 @@ def _merge_items(self, first_items, remaining_items, read_json=False) -> dict:
for key, item in items.items():
item.sort(key=lambda x: int(x["index"]["N"]))
for val in item:
raw_items[key] += bytes(val["val"]["B"])
if "val" in val:
raw_items[key] += bytes(val["val"]["B"])
if read_json:
for json_val in item:
try:
json_items[key] = json_val["json_val"]["S"]
json_items[key] += json_val["json_val"]["S"]
except Exception:
log.exception(f"json_val not found for key {key}")
# fallback to pickled data if json_val fails to exist for any key
Expand Down