U/kkasp/tron 2239 migrate pickle only state to json #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le and all pickles
…output failures to file
KaspariK
commented
Jan 8, 2025
| dump_json_key(source_table, key) | ||
|
|
||
|
|
||
| def delete_keys(source_table: ServiceResource, keys: List[str]) -> None: |
There was a problem hiding this comment.
Based on discussion with @nemacysts and @EmanElsaban we can probably do something here where we look for jobs that Tron doesn't know about and use that as the test for a valid delete
nemacysts
previously approved these changes
Jan 13, 2025
tools/pickles_to_json.py
Outdated
Comment on lines
470
to
474
| delete_keys_parser.add_argument( | ||
| "--dry-run", | ||
| action="store_true", | ||
| help="Simulate the deletion without making any changes to the DynamoDB table", | ||
| ) |
There was a problem hiding this comment.
i'm personally a fan of dry-run by default, but that's just me :p
There was a problem hiding this comment.
Good call.
I took the easier (lazy) path here with an --execute flag and just passed not args.execute to the existing dry_run logic. I am down to rewrite the conversion functions a bit to avoid the negative logic, but only if you comment that 😛
EmanElsaban
approved these changes
Jan 14, 2025
nemacysts
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script for working with pickle/json keys. Supports outputting, converting, and deleting.
TODO: probably worth incorporating some of luis' state restore script?