Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POC] auth support for paasta APIs #1005

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[POC] auth support for paasta APIs #1005

wants to merge 1 commit into from

Conversation

piax93
Copy link
Contributor

@piax93 piax93 commented Nov 7, 2024

This is a carbon copy of Yelp/paasta#3985, as eventually we'll want to have authentication on these APIs too.

@piax93 piax93 requested review from Qmando and danielpops November 7, 2024 15:30
@piax93 piax93 force-pushed the u/mpiano/SEC-19555 branch from 53e9e03 to 9f35622 Compare November 7, 2024 15:36
danielpops
danielpops approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@danielpops danielpops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's kind of a bummer that there's so much code dupe between paasta and tron, but a solution to address that (create another open source package for the common code) would be worse :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielpops danielpops danielpops approved these changes

@Qmando Qmando Awaiting requested review from Qmando

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piax93 @danielpops