feat: add configurable vertical position setting - #1
Open
MdTanjeemHaider wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The launcher window was always placed at a hardcoded physical y=100 regardless
of screen resolution. Monitors with different resolution put the window in odd locations at times.
This PR replaces the hardcoded value with a user-configurable "Vertical Position" setting (default: 30% from top, range: 5–85%).
Changes
src-tauri/src/main.rsWINDOW_Y_PERCENTstatic (default 30).compute_window_y_phys(). This calculates physical pixel offset from monitor height × percentage.get_window_y_percentTauri command.set_window_y_percentTauri command. The setter saves tosettings.jsonand immediately repositions the window for live preview.show_main_windowandreset_windowboth usecompute_window_y_physagainst the monitor the cursor is currently on.src/index.htmlsrc/main.jsTested on