BBF TR-477 YANG modules #1534
Merged
BBF TR-477 YANG modules #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
einarnn
approved these changes
Jan 20, 2024
einarnn
requested changes
Jan 20, 2024
There was a problem hiding this comment.
There seems to be an issue with some of the check scripts, seeing errors like this a number of times:
/home/runner/work/yang/yang/standard/bbf/standard/application/bbf-d-olt-pppoe-intermediate-agent.yang:36: error: module "ietf-crypto-types" not found in search path
/home/runner/work/yang/yang/standard/bbf/standard/application/bbf-d-olt-pppoe-intermediate-agent.yang:39: error: module "ietf-tcp-client" not found in search path
/home/runner/work/yang/yang/standard/bbf/standard/application/bbf-d-olt-pppoe-intermediate-agent.yang:42: error: module "ietf-tcp-server" not found in search path
/home/runner/work/yang/yang/standard/bbf/standard/application/bbf-d-olt-pppoe-intermediate-agent.yang:45: error: module "ietf-tls-client" not found in search path
/home/runner/work/yang/yang/standard/bbf/standard/application/bbf-d-olt-pppoe-intermediate-agent.yang:572: error: grouping "tls-server-grouping" not found in module "ietf-tls-server"
Errors in /home/runner/work/yang/yang/standard/bbf/standard/application/bbf-d-olt-mgmd.yang
Can you address this?
Cheers,
Einar
|
Thanks. I'll check on Monday. I fear that the problem may be that these modules are still drafts |
|
@wlupton, if that is the case you can adjust the paths used by pyang in your scripts until the models are approved, assuming the models are in the repo at all (experimental/draft models usually are). |
|
They're running successfully now |
|
@einarnn do i need to do something else before this can be merged? thanks |
einarnn
approved these changes
Jan 26, 2024
|
Thanks @einarnn. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.