Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: 마이페이지, 구매페이지 5차 QA #190

Merged
merged 12 commits into from
Jan 26, 2024
Merged

Fix: 마이페이지, 구매페이지 5차 QA #190

merged 12 commits into from
Jan 26, 2024

Conversation

seungsimdang
Copy link
Contributor

작업 개요 (이슈 번호)

#179

작업 내용 (변경 사항)

  • 필수약관 동의 클릭시 이용자 정보로 올라가는 현상 수정
  • 프로필 이미지 오류 해결
  • 회원 아이디 표기 오류 해결
  • isLocal 삭제
  • 거래내역서 수수료 소수점 표시
  • "야놀자에서 거래내역 확인" 클릭시 로직 추가
  • 결제페이지 이미지 사이즈 조절
  • 리스트카드 쉐도우 삭제
  • FCM 토큰 저장 로직 indexDB로 변경

스크린샷

  • 생략

테스트 결과

  • 이상 없습니당

리뷰 요청 사항

  • FCM 토큰 저장 로직 indexDB로 변경은 모바일에서 테스트 후 이상 있으면 롤백할게요!

close #179

@seungsimdang seungsimdang added the Fix Something isn't working label Jan 26, 2024
@seungsimdang seungsimdang self-assigned this Jan 26, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 26, 2024 •
edited
Loading

✅ Deploy Preview for animated-blini-88be51 ready!

Name Link
🔨 Latest commit a85db15
🔍 Latest deploy log https://app.netlify.com/sites/animated-blini-88be51/deploys/65b3ae9a2fa30b00086b3888
😎 Deploy Preview https://deploy-preview-190--animated-blini-88be51.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel Vercel
Copy link

vercel bot commented Jan 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
yanabada-fe-1r96 ✅ Ready (Inspect) Visit Preview Jan 26, 2024 1:07pm

wkdtnqls0506
wkdtnqls0506 approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@wkdtnqls0506 wkdtnqls0506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5차까지 완료티비!!

Gaoridang
Gaoridang approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@Gaoridang Gaoridang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳!!

@seungsimdang seungsimdang merged commit 7554d26 into develop Jan 26, 2024
8 checks passed
@seungsimdang seungsimdang deleted the feature/#179 branch January 26, 2024 13:18
Gaoridang pushed a commit to Gaoridang/Yanabada_FE that referenced this pull request Jul 26, 2024
@seungsimdang
Merge pull request Yanabada#190 from Yanabada/feature/Yanabada#179
40a331a 
Fix: 마이페이지, 구매페이지 5차 QA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gaoridang Gaoridang Gaoridang approved these changes

@wkdtnqls0506 wkdtnqls0506 wkdtnqls0506 approved these changes

@furaha707 furaha707 Awaiting requested review from furaha707

@SOL-MI SOL-MI Awaiting requested review from SOL-MI

Assignees

@seungsimdang seungsimdang

Labels
Fix Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix]: 마이페이지, 구매페이지 5차 QA
3 participants
@seungsimdang @wkdtnqls0506 @Gaoridang