Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow factories to be registered as specific types. #159

Merged
merged 2 commits into from
Oct 23, 2021
Merged

Allow factories to be registered as specific types. #159

merged 2 commits into from
Oct 23, 2021

Conversation

YairHalberstadt
Copy link
Owner

Fixes #151

@YairHalberstadt
Copy link
Owner Author

cc @jnm2

jnm2
jnm2 reviewed Oct 22, 2021
View reviewed changes
Copy link
Contributor

@jnm2 jnm2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests cover all my known use cases! Thank you!

@YairHalberstadt YairHalberstadt force-pushed the factory-method-as-types branch 2 times, most recently from d691b27 to 9492386 Compare October 23, 2021 17:59
@YairHalberstadt YairHalberstadt force-pushed the factory-method-as-types branch from 9492386 to 8f3ce9a Compare October 23, 2021 18:01
@YairHalberstadt YairHalberstadt merged commit 781ff22 into main Oct 23, 2021
@YairHalberstadt YairHalberstadt deleted the factory-method-as-types branch October 23, 2021 18:24
@YairHalberstadt
Copy link
Owner Author

@jnm2 I've pushed a 1.3.0 release with these and the IOwned changes

@jnm2
Copy link
Contributor

jnm2 commented Oct 23, 2021

This will be fun to use! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnm2 jnm2 jnm2 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'registerAs' parameter for FactoryAttribute
2 participants
@YairHalberstadt @jnm2