-
Notifications
You must be signed in to change notification settings - Fork 0
[TNT-269] 식단 기록 상세 모듈 분리 #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoyahozz
reviewed
Apr 10, 2025
| Toast.makeText(context, effect.message, Toast.LENGTH_SHORT).show() | ||
| } | ||
|
|
||
| TraineeMealDetailSideEffect.NavigateToHome -> TODO() |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
질문) 요거는 왜 TODO() 가 되었나용? ㅎㅎ
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
마이 미스테이크.. 수정했습니다! 80d06f8
Member
|
👍👍👍👍👍👍👍👍👍👍👍👍 |
hoyahozz
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
trainee:mealdetail모듈을 새로 생성하고, 식단 기록 상세 관련 코드를 해당 모듈로 이동했습니다.기존
trainee:mealrecord모듈에 포함되어 있던 식단 기록 상세 관련 코드는 제거했습니다.78d4454TraineeMainRoute와TraineeMainScreen에서 navigateToMealRecord, navigateToMealDetail 파라미터를 제거했습니다.👉 식단 관련 네비게이션은
NavController의 확장 함수로 직접 처리하도록 수정했습니다.MealRecord,MealDetail화면을traineeHomeNavGraph내부 중첩 그래프로 이동했습니다.TnTNavHost에서traineeMealRecordScreen를 제거했습니다.📸 실행 화면
default.mp4
🙆🏻 리뷰 요청 사항
👀 레퍼런스