Skip to content

Conversation

@jihun32
Copy link

@jihun32 jihun32 commented Jan 4, 2026

🔗 관련 이슈

📙 작업 내역

  • SharedThirpartyLib 관리 모듈 구현
  • Layer별 Root 모듈 구현
  • MainTabView IA 기반 임시 구현

🎨 스크린샷 또는 시연 영상 (선택)

| MainTabView |

✅ PR 체크리스트

  • 커밋 메시지가 명확합니다
  • PR 제목이 컨벤션에 맞습니다
  • 관련 이슈 번호를 작성했습니다
  • 기능이 정상적으로 작동합니다
  • 불필요한 코드를 제거했습니다

💬 추가 설명 or 리뷰 포인트 (선택)

  • MainTab 관련해서는 Feature Root 모듈에서 다루는걸로 하고, 따로 FeatureRootView, Reducer를 만들지 않고 바로 MainTab으로 이어지게 작업했어
    => FeatureRootView, Reducer로 하면 MainTab 모듈을 만들어야 한다고 생각하는데 MainTab을 모듈로 만들었을 때 다른 곳에서 재사용할 경우가 없을거라고 생각해 모듈로 만들 필요 없다고 생각함
  • Info.plist에 Launch Screen 추가 안하면 빌드했을 때 위 아래가 검정색으로 채워지고 뷰가 크롭하게 나오더라구 알고 있을 거 같은데 혹시 몰라서 적어놓을게~
  • "변수, 함수 등의 선언 순서 및 개행은 아래의 형식을 따른다." 노션에 코드 컨벤션 관련해서 이 부분 적용해서 작업 진행했는데 저번에 한 번 말하긴 했는데 View, Reducer의 경우 body(계산 프로퍼티)가 강제적이고 보통 그 위에 init을 구현해가지구 이 부분은 안지키고 작업했는데 해당 부분 인지하고 리뷰해줘!

@coderabbitai
Copy link

coderabbitai bot commented Jan 4, 2026

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'tools'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

@coderabbitai summary

@coderabbitai
Copy link

coderabbitai bot commented Jan 4, 2026

The author of this PR is on the CodeRabbit Free Plan. In order to use the Chat feature, please upgrade the PR author to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Copy link
Member

@clxxrlove clxxrlove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고했어 !!

public var body: some View {
VStack {
TabView {
Text("홈")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분은 추후 수정하는걸로

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿

@clxxrlove clxxrlove merged commit e6e782a into develop Jan 6, 2026
7 checks passed
@clxxrlove clxxrlove deleted the feat/#30 branch January 6, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants