fix(tool): redact permission result reasons - #93
Open
XnLemon wants to merge 115 commits into
Open
Conversation
XnLemon
force-pushed
the
codex/phase2-secret-rotation-redaction
branch
from
July 11, 2026 13:38
1f129b4 to
2862417
Compare
XnLemon
force-pushed
the
codex/phase2-tool-metadata-redaction
branch
from
July 11, 2026 13:38
81ad3f1 to
e163f51
Compare
XnLemon
changed the base branch from
codex/phase2-secret-rotation-redaction
to
main
July 13, 2026 02:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Close one Phase2 governance redaction gap where permission result reasons are returned to the model.
Changes
PermissionResultForreasons for denied and approval-required tool calls.ApprovalDeniedResultForreasons returned after reviewer rejection.sk-tokens, JSON secret fields, and private-key blocks without adding a reverse dependency fromtooltoplatform.Validation
go test ./toolgo test ./internal/flow/processor -run Permission|ApprovalDenied|ToolPermissiongo test ./tool/dynamicworkflow ./platform/toolpolicygo vet ./tool ./internal/flow/processor ./tool/dynamicworkflow ./platform/toolpolicygit diff --checkKnown Risks / Limitations
go test ./internal/flow/processorrun on Windows still hits existing path separator assertions in skill path tests, unrelated to this change.Follow-up