Skip to content

fix(tool): redact permission result reasons - #93

Open
XnLemon wants to merge 115 commits into
mainfrom
codex/phase2-tool-metadata-redaction
Open

fix(tool): redact permission result reasons#93
XnLemon wants to merge 115 commits into
mainfrom
codex/phase2-tool-metadata-redaction

Conversation

@XnLemon

@XnLemon XnLemon commented Jul 11, 2026

Copy link
Copy Markdown
Owner

Objective

Close one Phase2 governance redaction gap where permission result reasons are returned to the model.

Changes

  • Redact PermissionResultFor reasons for denied and approval-required tool calls.
  • Redact ApprovalDeniedResultFor reasons returned after reviewer rejection.
  • Cover Authorization, Cookie, api_key/token/password/secret/passwd, URL userinfo, OpenAI-style sk- tokens, JSON secret fields, and private-key blocks without adding a reverse dependency from tool to platform.
  • Add regression tests for permission denial, approval-required, approval-denied, generic Authorization fallback, and multi-value Cookie headers.

Validation

  • go test ./tool
  • go test ./internal/flow/processor -run Permission|ApprovalDenied|ToolPermission
  • go test ./tool/dynamicworkflow ./platform/toolpolicy
  • go vet ./tool ./internal/flow/processor ./tool/dynamicworkflow ./platform/toolpolicy
  • git diff --check
  • open-code-review subagent loop: final review 0 High / 0 Medium / 0 Low

Known Risks / Limitations

  • Scope is intentionally limited to permission-result reason strings returned to the model.
  • A broader go test ./internal/flow/processor run on Windows still hits existing path separator assertions in skill path tests, unrelated to this change.

Follow-up

  • Continue Phase2 closure sweep across remaining governance and redaction output boundaries in the next stacked increment.

XnLemon added 30 commits July 8, 2026 11:47
@XnLemon
XnLemon force-pushed the codex/phase2-secret-rotation-redaction branch from 1f129b4 to 2862417 Compare July 11, 2026 13:38
@XnLemon
XnLemon force-pushed the codex/phase2-tool-metadata-redaction branch from 81ad3f1 to e163f51 Compare July 11, 2026 13:38
@XnLemon
XnLemon changed the base branch from codex/phase2-secret-rotation-redaction to main July 13, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants