Skip to content

fix(artifactstore): redact storage errors - #88

Open
XnLemon wants to merge 110 commits into
mainfrom
codex/phase2-storage-error-redaction
Open

fix(artifactstore): redact storage errors#88
XnLemon wants to merge 110 commits into
mainfrom
codex/phase2-storage-error-redaction

Conversation

@XnLemon

@XnLemon XnLemon commented Jul 11, 2026

Copy link
Copy Markdown
Owner

Objective

Close a Phase2 storage-error redaction gap by ensuring artifact store service boundaries do not expose raw storage backend errors containing credentials or tokens.

Changes

  • Added a redacted storage error wrapper for external metadata/object store errors.
  • Preserved errors.Is / unwrap semantics while redacting Error() output.
  • Applied the wrapper to artifact metadata query/reserve/activate/delete and object get/put/delete paths.
  • Added regression coverage for DSN password, Authorization bearer token, and API key leakage in storage errors.

Validation

  • go test ./platform/artifactstore
  • go vet ./platform/artifactstore
  • git diff --check
  • open-code-review subagent review: 0 High / 0 Medium / 0 Low

Known Risks / Limitations

  • Error text remains intentionally sanitized; callers needing exact backend details should inspect wrapped errors through controlled internal diagnostics rather than user-facing logs/responses.

Follow-up

  • Continue Phase2 closure on the next independently reviewable governance/security gap.

XnLemon added 30 commits July 8, 2026 11:47
@XnLemon
XnLemon force-pushed the codex/phase2-config-output-redaction branch from 77d0776 to ddb6fd8 Compare July 11, 2026 13:38
@XnLemon
XnLemon force-pushed the codex/phase2-storage-error-redaction branch from 9850d9c to 50d976d Compare July 11, 2026 13:38
@XnLemon
XnLemon changed the base branch from codex/phase2-config-output-redaction to main July 13, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants