Repository navigation
push: add the missing money switch - #101
Merged
Merged
Conversation
Money notifications were mapped to a "money" setting that was not in the defaults or the settings template, so they were always on and the screen had no switch. Add the switch, default it on, and cover it in the push test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Money notifications were mapped to a
moneyswitch that was missing from bothDEFAULTSand the settings template. As a resultpushDuetreated money as always on, and the push settings screen had no way to turn it off.This adds the switch (default on), bumps the template checksum so clients pick up the new entry, and extends
scripts/test-push.tsto check the default, the template entry, and savingmoney: "off". The script is added to the HTTP test step.The new checks fail on main:
push_settings.moneyis absent and the template has nomoneyentry.Tests:
bun run test:unitbun scripts/test-push.ts ci_api_a ci_api_b testpass123against a disposable local database and server