Target to net 7 and 8 in addition to 6

[virzak]

Description:

Fixes # (issue)

Checklist:

• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I have tested my changes by running the extension in VS2017
• I have tested my changes by running the extension in VS2019
• I have tested my changes by running the extension in VS2022
• If changes to the documentation are needed, I have noted this in the description above

[grochocki]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[grochocki]

Thank you for the PR! A couple questions, but this otherwise generally looks good.

[hansmbakker]

Given that .NET 7 goes out of support on May 14, 2024, I'd suggest adding only .NET 8 instead of 7 and 8.

Other than that, great that you're contributing this!

[hansmbakker]

@grochocki having .NET 8 support would really be a welcome update, so that users are not forced to install .NET 6 to run the XamlStyler CLI.

Would it be an idea to do the targetframework update to .NET 8 independent of the other changes in this PR (dependency to Newtonsoft.Json, change in VS SDK version, allowPrerelease in global.json), to unblock this?

(In the meantime, I can add a .NET 8 version of the CLI to my private nuget feed as a workaround)

[hansmbakker]

is this still needed?

[virzak]

Makes no difference for .NET 8, but when .NET 9 comes out, we'll need this. Some people including myself switch to preview early, so I vote to leave this in.

[heartacker]

hi，all，can any body tell that what block this, thanks

[MarkPflug]

Instead of multi-targeting, I'd suggest adding a <RollForward>Major to the xstyle .csproj. This would allow you to continue to build against a single framework version (6.0), but allow the tool to run on future versions without needing to be updated.

https://learn.microsoft.com/en-us/dotnet/core/versions/selection#control-roll-forward-behavior

[nietras]

We have seen the same issue with XamlStyler and think it would be great if RollForward Major was supported as @MarkPflug mentions.

[virzak]

Instead of multi-targeting, I'd suggest adding a <RollForward>Major to the xstyle .csproj. This would allow you to continue to build against a single framework version (6.0), but allow the tool to run on future versions without needing to be updated.

https://learn.microsoft.com/en-us/dotnet/core/versions/selection#control-roll-forward-behavior

@MarkPflug That works too. @grochocki what's your opinion?

[heartacker]

anyupdate?

[Jeanjean]

What can we do to get this MR completed?

[virzak]

You can just use in order to avoid installing .NET 6:

dotnet tool run xstyler --allow-roll-forward