Better handle internal VS exceptions relating to .csproj files (#453)

Co-authored-by: Dave Grochocki <[email protected]>
Xavalon · Dec 27, 2023 · ad7aa2e · ad7aa2e
1 parent fc1107c
commit ad7aa2e
Show file tree

Hide file tree

Showing 2 changed files with 45 additions and 7 deletions.
diff --git a/src/XamlStyler.Extension.Windows.Shared/Extensions/DocumentExtensions.cs b/src/XamlStyler.Extension.Windows.Shared/Extensions/DocumentExtensions.cs
@@ -30,13 +30,29 @@ public static bool IsAvaloniaXaml(this Document document)
                    && document.FullName.EndsWith(Constants.AxamlFileExtension, StringComparison.OrdinalIgnoreCase);
         }
 
+        public static bool IsReadOnly(this Document document)
+        {
+            ThreadHelper.ThrowIfNotOnUIThread();
+
+            try
+            {
+                return document.ReadOnly;
+            }
+            catch
+            {
+                // EnvDTE.Document.get_ReadOnly() *may* throw an Exception for some document types.
+            }
+
+            return false;
+        }
+
         public static XamlLanguageOptions GetXamlLanguageOptions(this Document document)
         {
             ThreadHelper.ThrowIfNotOnUIThread();
 
             var options = new XamlLanguageOptions();
 
-            if (document == null || document.ReadOnly)
+            if (document == null || document.IsReadOnly())
             {
                 return options;
             }

diff --git a/src/XamlStyler.Extension.Windows.Shared/StylerPackage.cs b/src/XamlStyler.Extension.Windows.Shared/StylerPackage.cs
@@ -75,7 +75,7 @@ private void AddCommandHandlers()
 
             // Format XAML File Command
             this.menuCommandService.AddCommand(new MenuCommand(
-                (s,e) => this.FormatFileEventHandler(),
+                (s, e) => this.FormatFileEventHandler(),
                 new CommandID(Guids.GuidXamlStylerMenuSet, (int)Constants.CommandIDFormatXamlFile)));
 
             // Format All XAML Command
@@ -101,7 +101,10 @@ private void FormatFileEventHandler()
         {
             ThreadHelper.ThrowIfNotOnUIThread();
             this.uiShell.SetWaitCursor();
-            this.FormatDocument(this.IDE2.ActiveDocument);
+            if (TryGetActiveDocument(out Document document))
+            {
+                this.FormatDocument(document);
+            }
         }
 
         private void FormatSolutionEventHandler()
@@ -135,11 +138,13 @@ private void OnFileSave(string guid, int id, object customIn, object customOut,
                 return;
             }
 
-            Document document = this.IDE2.ActiveDocument;
-            IStylerOptions options = this.optionsHelper.GetDocumentStylerOptions(document);
-            if (options.FormatOnSave)
+            if (TryGetActiveDocument(out Document document))
             {
-                this.FormatDocument(document, options);
+                IStylerOptions options = this.optionsHelper.GetDocumentStylerOptions(document);
+                if (options.FormatOnSave)
+                {
+                    this.FormatDocument(document, options);
+                }
             }
         }
 
@@ -180,6 +185,23 @@ private void OnFileSaveAll(string guid, int id, object customIn, object customOu
             }
         }
 
+        private bool TryGetActiveDocument(out Document document)
+        {
+            ThreadHelper.ThrowIfNotOnUIThread();
+            try
+            {
+                document = this.IDE2.ActiveDocument;
+                return document != null;
+            }
+            catch
+            {
+                // EnvDTE80.DTE2.get_ActiveDocument() *may* throw an ArgumentNullException for some documents.
+            }
+
+            document = null;
+            return false;
+        }
+
         private void ShowMessageBox(Exception ex)
         {
             ThreadHelper.ThrowIfNotOnUIThread();