Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add health cheks vault #2249

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

SaeedSafi1999
Copy link

@SaeedSafi1999 SaeedSafi1999 commented Jun 23, 2024

What this PR does / why we need it:
add hashicorp vault to reposiotiry
Which issue(s) this PR fixes:
add all of the Common authentication methods like LDAP,OKTA,RADIUS,Vault token
Please reference the issue this PR will close: #2239

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing
  • End-to-end tests passing
  • Extended the documentation
  • Provided sample for the feature

@github-actions github-actions bot added the UI label Jun 23, 2024
@SaeedSafi1999
Copy link
Author

@dotnet-policy-service agree

@Alirexaa Alirexaa added enhancement New feature or request and removed UI labels Jun 24, 2024
@Alirexaa Alirexaa requested a review from adamsitnik June 24, 2024 22:42
@Alirexaa
Copy link
Collaborator

@adamsitnik, can you add ci/cd workflows for this?

AspNetCore.Diagnostics.HealthChecks.sln Outdated Show resolved Hide resolved
AspNetCore.Diagnostics.HealthChecks.sln Outdated Show resolved Hide resolved
HealthChecks.Vault.Tests/HealthCheckVaultTest.cs Outdated Show resolved Hide resolved
HealthChecks.Vault.Tests/HealthCheks.Vault.Tests.csproj Outdated Show resolved Hide resolved
HealthChecks.Vault.Core.Tests/UnitTest1.cs Outdated Show resolved Hide resolved
HealthChecks.Vault.Core.Tests/UnitTest1.cs Outdated Show resolved Hide resolved
HealthChecks.Vault.Core.Tests/UnitTest1.cs Outdated Show resolved Hide resolved
HealthChecks.Vault.Core.Tests/UnitTest1.cs Outdated Show resolved Hide resolved
HealthChecks.Vault.Core.Tests/UnitTest1.cs Outdated Show resolved Hide resolved
@SaeedSafi1999
Copy link
Author

SaeedSafi1999 commented Jul 3, 2024

@Alirexaa please review code and tell me change if need.
thanks

@SaeedSafi1999 SaeedSafi1999 requested a review from Alirexaa July 4, 2024 21:04
@SaeedSafi1999
Copy link
Author

@Alirexaa ptl

Copy link
Collaborator

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SaeedSafi1999 thank you for your contribution! PTAL at my comments.

src/HealthChecks.Vault/HealthChecksVault.cs Outdated Show resolved Hide resolved
ApiMarker.cs Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of having this empty file?

src/HealthChecks.UI/assets/1ae4e3706fe3f478fcc1.woff2 Outdated Show resolved Hide resolved
src/HealthChecks.Uris/HealthChecks.Uris.csproj Outdated Show resolved Hide resolved

public VaultContainerFixture()
{
_container = new ContainerBuilder()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this repo we typically configure the containers from github workflow level, here you can find some examples of how we do that:

https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/blob/master/.github/workflows/healthchecks_redis_cd.yml
https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/blob/master/.github/workflows/healthchecks_redis_cd_preview.yml
https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/blob/master/.github/workflows/healthchecks_redis_ci.yml

could you please do that for this project as well (we need that to be able to run the tests in the CI) and remove the dependency to Testcontainers?

I am not saying that Testcontainers are bad (it actually looks very neat), we just use a different approach in this repo and I would prefer for all of the health checks to implement the same pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppurt Hashicorp Vault
3 participants