fix(rbc): throw error instead of throwing away unknown fields

[mvadari]

High Level Overview of Change

This PR fixes an issue in ripple-binary-codec to throw an error instead of silently throwing away unknown fields and their values when serializing transactions.

It only errors on CapitalizedFields and still silently ignores lowercaseFields, as the latter are likely from copy-pasting tx outputs or something, rather than an actual error (since all rippled fields must be Capitalized).

Context of Change

I came across this issue when working on a separate PR for a new feature, where my tests would fail for unknown reasons. I had to go into the rippled logs and decode the transaction rippled was receiving to figure out what was happening.

Type of Change

• Bug fix (non-breaking change which fixes an issue)

Did you update HISTORY.md?

• Yes

Test Plan

Added a test to make sure this works properly, and fixed existing tests that had the previous assumption.

[coderabbitai]

Walkthrough

The changes introduce a new function, isValidFieldInstance, to improve validation logic for field instances in the ripple-binary-codec package. The sorting logic for fields has been refactored to enhance error handling for undefined fields. Additionally, the encoding process now throws errors for transactions with undefined or unknown fields, with corresponding test cases updated to reflect this behavior. The HISTORY.md file has been modified to document these changes.

Changes

File(s)	Change Summary
packages/ripple-binary-codec/src/types/st-object.ts	Added the function isValidFieldInstance for field validation and refactored inline filtering for sorting fields, enhancing error handling for undefined fields.
packages/ripple-binary-codec/test/definitions.test.ts packages/ripple-binary-codec/test/tx-encode-decode.test.ts	Updated tests to expect errors when encoding transactions with undefined or unknown fields instead of silently ignoring them; adjusted assertions and comments accordingly.
packages/ripple-binary-codec/HISTORY.md	Updated documentation to note that unknown fields now trigger an error rather than being silently ignored.

Suggested reviewers

• ckeshava
• achowdhry-ripple
• pdp2121

Poem

I'm a little rabbit on a coding spree,
Hoping through fields with clarity,
Validation and errors, all in a row,
Ensuring the bugs have nowhere to go.
My hops are swift, my tests align,
In this code garden, all is fine!
🐇💻

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c0eaa7e and a1d0be1.

📒 Files selected for processing (1)

• packages/ripple-binary-codec/HISTORY.md (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• packages/ripple-binary-codec/HISTORY.md

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[mvadari]

This function is needed for typing