fix: XRP Issue 40-byte encoding, nil opts guards, public ComputeSigna…#193
Draft
panterose wants to merge 1 commit intoXRPLF:mainfrom
Draft
fix: XRP Issue 40-byte encoding, nil opts guards, public ComputeSigna…#193panterose wants to merge 1 commit intoXRPLF:mainfrom
panterose wants to merge 1 commit intoXRPLF:mainfrom
Conversation
…ture - issue.go: XRP Issues now return 40 bytes (currency + issuer zeros) for consistency - issue_test.go: Updated tests to expect 40-byte XRP encoding - client.go: Added nil guards for opts in SubmitTx and SubmitTxAndWait - wallet.go: Added public ComputeSignature for dual-signing (XLS-66)
96766f0 to
e44e340
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
We are building an invoice factoring platform on XRPL using XLS-65 (Single Asset Vault) and XLS-66 (Lending Protocol) together. The workflow involves:
Issues Encountered
VaultCreate failing with `invalidTransaction`:
LoanSet dual-signing not possible:
Nil pointer dereference:
Type of change
Checklist:
Changes
Testing