Skip to content

Conversation

@Tapanito
Copy link
Collaborator

@Tapanito Tapanito commented Dec 8, 2025

Adds a check to ensure vault asset cap is not exceeded when creating a Loan.

@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.1%. Comparing base (f7a5f35) to head (bd1cea0).

Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                        @@
##           ximinez/lending-XLS-66-ongoing   #6124     +/-   ##
================================================================
- Coverage                            79.1%   79.1%   -0.0%     
================================================================
  Files                                 839     839             
  Lines                               71380   71384      +4     
  Branches                             8318    8319      +1     
================================================================
+ Hits                                56476   56478      +2     
- Misses                              14904   14906      +2     
Files with missing lines Coverage Δ
src/xrpld/app/tx/detail/LoanSet.cpp 91.5% <100.0%> (+0.1%) ⬆️

... and 5 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@gregtatcam gregtatcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants