Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically links libstd++ and libgcc #5373

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

bthomee
Copy link
Collaborator

@bthomee bthomee commented Mar 27, 2025

High Level Overview of Change

Dynamically links libstd++ and libgcc to reduce binary bloat and enhance compatibility with dependencies.

Context of Change

Currently libstd++ and libgcc are statically linked into the Linux rippled binary. This is helpful in situations where the binary is run on systems that have different versions of these libraries. However, statically linking also has downsides, such as bloating the binary and an inability to use certain other dependencies that use dlsym.

By dynamically linking these libraries we keep the binary lean, and since rippled is not typically run on minimal distros that don't have them already installed, but instead on standard systems that will have them, the binary will generally run as expected. If not, these standard libraries can be easily installed.

See also #5372

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

For Linux developers, nothing will change as the build tools already include libstd++ and libgcc. For those running from a package, their Linux machines will need to manually install libstd++ and libgcc to run a precompiled binary until the packages have been updated to install these build tools automatically.

Future Tasks

Update the rippled packages to install libstd++ and libgcc if not yet present.

@bthomee bthomee marked this pull request as ready for review March 27, 2025 18:14
@bthomee bthomee requested review from Bronek and ximinez March 27, 2025 18:14
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.1%. Comparing base (6cf37c4) to head (295a5a9).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5373   +/-   ##
=======================================
  Coverage     78.1%   78.1%           
=======================================
  Files          795     795           
  Lines        68447   68448    +1     
  Branches      8277    8273    -4     
=======================================
+ Hits         53482   53491    +9     
+ Misses       14965   14957    -8     

see 3 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant