Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unify rippled to use east const convention #5368

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Tapanito
Copy link

This PR refactors ripped codebase to consistently use east const convention. Furthermore, it adds a clang-format rule to enforce this formatting.

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 91.92825% with 18 lines in your changes missing coverage. Please review.

Project coverage is 78.1%. Comparing base (fc20477) to head (5a7ef72).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/libxrpl/json/json_valueiterator.cpp 61.5% 5 Missing ⚠️
src/xrpld/core/detail/Job.cpp 25.0% 3 Missing ⚠️
src/xrpld/overlay/detail/PeerImp.cpp 33.3% 2 Missing ⚠️
include/xrpl/protocol/STArray.h 50.0% 1 Missing ⚠️
src/libxrpl/json/json_reader.cpp 83.3% 1 Missing ⚠️
src/libxrpl/protocol/STBase.cpp 80.0% 1 Missing ⚠️
src/libxrpl/protocol/Serializer.cpp 75.0% 1 Missing ⚠️
src/xrpld/app/main/Main.cpp 0.0% 1 Missing ⚠️
src/xrpld/app/misc/NetworkOPs.cpp 83.3% 1 Missing ⚠️
src/xrpld/net/detail/HTTPClient.cpp 75.0% 1 Missing ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5368     +/-   ##
=========================================
- Coverage     78.1%   78.1%   -0.0%     
=========================================
  Files          795     795             
  Lines        68447   68447             
  Branches      8274    8277      +3     
=========================================
- Hits         53490   53483      -7     
- Misses       14957   14964      +7     
Files with missing lines Coverage Δ
include/xrpl/basics/BasicConfig.h 87.2% <100.0%> (ø)
include/xrpl/basics/CompressionAlgorithms.h 0.0% <ø> (ø)
include/xrpl/basics/Expected.h 100.0% <ø> (ø)
include/xrpl/basics/TaggedCache.h 100.0% <ø> (ø)
include/xrpl/basics/TaggedCache.ipp 85.6% <ø> (ø)
include/xrpl/basics/base_uint.h 96.8% <100.0%> (ø)
include/xrpl/basics/partitioned_unordered_map.h 99.2% <ø> (ø)
include/xrpl/basics/tagged_integer.h 100.0% <100.0%> (ø)
include/xrpl/beast/utility/temp_dir.h 100.0% <ø> (ø)
include/xrpl/json/json_reader.h 100.0% <ø> (ø)
... and 129 more

... and 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Tapanito Tapanito force-pushed the refactor/east-const branch from e12d88b to 8581ede Compare March 27, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant