Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Nodes communication via DB #1976

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from

Conversation

kuznetsss
Copy link
Collaborator

Fixes #1966.

@kuznetsss kuznetsss changed the title 1966 nodes communication via db feat: Nodes communication via DB Mar 26, 2025
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 84.90566% with 16 lines in your changes missing coverage. Please review.

Project coverage is 73.44%. Comparing base (427ba47) to head (77e2f89).
Report is 37 commits behind head on develop.

Files with missing lines Patch % Lines
src/cluster/ClusterCommunicationService.cpp 86.90% 7 Missing and 4 partials ⚠️
src/cluster/ClioNode.cpp 72.72% 1 Missing and 2 partials ⚠️
src/app/ClioApplication.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1976      +/-   ##
===========================================
+ Coverage    72.71%   73.44%   +0.72%     
===========================================
  Files          333      346      +13     
  Lines        13525    14177     +652     
  Branches      6881     7202     +321     
===========================================
+ Hits          9835    10412     +577     
- Misses        1785     1818      +33     
- Partials      1905     1947      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 22 changed files in this pull request and generated no comments.

Files not reviewed (20)
  • src/CMakeLists.txt: Language not supported
  • src/app/CMakeLists.txt: Language not supported
  • src/cluster/CMakeLists.txt: Language not supported
  • src/cluster/ClioNode.cpp: Language not supported
  • src/cluster/ClioNode.hpp: Language not supported
  • src/cluster/ClusterCommunicationService.cpp: Language not supported
  • src/cluster/ClusterCommunicationService.hpp: Language not supported
  • src/cluster/ClusterCommunicationServiceInterface.hpp: Language not supported
  • src/data/BackendInterface.hpp: Language not supported
  • src/data/CassandraBackend.hpp: Language not supported
  • src/data/cassandra/Schema.hpp: Language not supported
  • src/data/cassandra/impl/Result.hpp: Language not supported
  • src/data/cassandra/impl/Statement.hpp: Language not supported
  • src/etlng/impl/ext/Core.cpp: Language not supported
  • src/util/TimeUtils.cpp: Language not supported
  • src/util/TimeUtils.hpp: Language not supported
  • tests/common/util/MockBackend.hpp: Language not supported
  • tests/integration/data/cassandra/BackendTests.cpp: Language not supported
  • tests/unit/CMakeLists.txt: Language not supported
  • tests/unit/cluster/ClioNodeTests.cpp: Language not supported

Copy link
Collaborator

@PeterChen13579 PeterChen13579 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀
Just a few questions

Copy link
Collaborator

@PeterChen13579 PeterChen13579 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nodes communication via DB
2 participants