-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Nodes communication via DB #1976
base: develop
Are you sure you want to change the base?
feat: Nodes communication via DB #1976
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1976 +/- ##
===========================================
+ Coverage 72.71% 73.44% +0.72%
===========================================
Files 333 346 +13
Lines 13525 14177 +652
Branches 6881 7202 +321
===========================================
+ Hits 9835 10412 +577
- Misses 1785 1818 +33
- Partials 1905 1947 +42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 22 changed files in this pull request and generated no comments.
Files not reviewed (20)
- src/CMakeLists.txt: Language not supported
- src/app/CMakeLists.txt: Language not supported
- src/cluster/CMakeLists.txt: Language not supported
- src/cluster/ClioNode.cpp: Language not supported
- src/cluster/ClioNode.hpp: Language not supported
- src/cluster/ClusterCommunicationService.cpp: Language not supported
- src/cluster/ClusterCommunicationService.hpp: Language not supported
- src/cluster/ClusterCommunicationServiceInterface.hpp: Language not supported
- src/data/BackendInterface.hpp: Language not supported
- src/data/CassandraBackend.hpp: Language not supported
- src/data/cassandra/Schema.hpp: Language not supported
- src/data/cassandra/impl/Result.hpp: Language not supported
- src/data/cassandra/impl/Statement.hpp: Language not supported
- src/etlng/impl/ext/Core.cpp: Language not supported
- src/util/TimeUtils.cpp: Language not supported
- src/util/TimeUtils.hpp: Language not supported
- tests/common/util/MockBackend.hpp: Language not supported
- tests/integration/data/cassandra/BackendTests.cpp: Language not supported
- tests/unit/CMakeLists.txt: Language not supported
- tests/unit/cluster/ClioNodeTests.cpp: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 🚀
Just a few questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Fixes #1966.