Skip to content

Fix issue #1141 #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 21, 2024
Merged

Fix issue #1141 #1142

merged 3 commits into from
Aug 21, 2024

Conversation

qtfkwk
Copy link
Contributor

@qtfkwk qtfkwk commented Aug 20, 2024 •
edited
Loading

Summary of fixes:

  • Added empty json feature and included in all
  • Removed unnecessary Cli.verbose property
  • Removed unnecessary NumberFormatStyle.all() method
  • Added doc strings for pub constants in src/consts.rs
  • Exported self::consts::* in src/lib.rs
  • Removed unused AsciiExt.is_not_line_ending_whitespace() method

@qtfkwk qtfkwk mentioned this pull request Aug 20, 2024
Open
@qtfkwk
Copy link
Contributor Author

qtfkwk commented Aug 20, 2024 •
edited
Loading

  • Added empty json feature and included in all

Had to roll back the first item due to that fix causing build issues in checks.

AFAICT prior recent releases v13.0.0-alpha{1,2} also produced these warnings so it is not related to #1137, #1138, or subsequent PRs.

Unsure if/how @XAMPPRocky et al want to address those?

@XAMPPRocky
Copy link
Owner

Thank you for your PR!

@XAMPPRocky XAMPPRocky merged commit 2645a11 into XAMPPRocky:master Aug 21, 2024
71 checks passed
@github-actions github-actions bot mentioned this pull request Aug 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qtfkwk @XAMPPRocky