Spike filter default #105
Merged
Spike filter default #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tomnis
commented
Sep 28, 2023
tomnis
commented
- no default values for spike filter warp properties.
- minor query tweaks to pass idTestDefinition instead of test exections, should be easier to use in calling code.
hbonilla2
approved these changes
Sep 28, 2023
| @@ -87,8 +87,8 @@ trait ArbiterLike extends PersistenceAware with CanReadHistory { | |||
| * | |||
| * @return spike filtering settings. | |||
| */ | |||
| def spikeFilterSettings[T: TestExecutionRowLikeType](testExecution: T): (Boolean, Int) = { | |||
| var settings: (Boolean, Int) = this.persistenceUtils.getSpikeFilterSettings(testExecution) | |||
| def spikeFilterSettings(idTestDefinition: Int): (Boolean, Int) = { | |||
| @@ -59,8 +59,8 @@ trait CanReadHistory extends CorePersistenceAware { | |||
| require(maybePriorExecutions.length <= historySize) | |||
|
|
|||
| maybePriorExecutions.length == historySize && maybePriorExecutions.forall { execution => | |||
| val tag = this.persistenceUtils.getTagName(tagName) | |||
| this.persistenceUtils.getTestExecutionTagsRowSafe(execution.idTestExecution, tag.idTagName).nonEmpty | |||
| val maybeTag: Option[TagNameRowLike] = this.persistenceUtils.getTagName(tagName) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.