Revert "Fix: Register Akismet Anti-Spam as a connector."

[peterwilsoncc]

This reverts commit c5627a1.

Reverts Akismet connector registration from WordPress Core in favor of requiring the plugin register the connector.

Trac ticket: https://core.trac.wordpress.org/ticket/65012#comment:12

Use of AI Tools

Nil

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props peterwilsoncc, jorbin, jorgefilipecosta, desrosj.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[aaronjorbin]

nit: I like that the example is for something that isn't ai_provider as the type since it shows that the API is for more than just AI.

[peterwilsoncc]

Good point, back to spam filtering in 12921e9

[jorgefilipecosta]

For now, Akismet cannot register its own connector that appear on the connectors screen before the plugin is activated. PR #11399 includes the required metadata so the connector appears before activation, just like OpenAI, Anthropic, and Google. For OpenAI, Anthropic, and Google, they even appear before installation, which is not the case for Akismet. Showing Akismet before activation was discussed with the release lead @mtias.

[desrosj]

Showing Akismet before activation was discussed with the release lead @mtias.

@jorgefilipecosta Can you share a link to where this discussion took place for others to read through so that the goals of this can be better understood? I apologize if I'm missing it, but it's difficult to support a change within an open project when there is no public record of the rationale or how it was tested within the community.

For now, Akismet cannot register its own connector that appear on the connectors screen before the plugin is activated. PR #11399 includes the required metadata so the connector appears before activation, just like OpenAI, Anthropic, and Google. For OpenAI, Anthropic, and Google, they even appear before installation, which is not the case for Akismet.

I'm not clear on why it's desirable for Akismet to be visible as an available connection before being activated. How does this scale? Is the expectation that any installed plugin can add their connection details to this page when they are deactivated? I'm not sure how that scales and I think that will certainly be abused.

It's true that the OpenAI, Anthropic, and Google connectors appear before being installed and/or activated, but these are accompanied by a specific call to action educating the user about the AI plugin and the supported models. Yes, the page is meant to house all API keys, but in my opinion, there should be two types of connections: AI connector plugins and everything else.

As the page sits before r62193, the bottom of the list has a link to "search the plugin directory to see if a connector is available" which searches the connector tag on the directory. Akismet does not show up there because it's not (and should not be) tagged as a connector, which makes it feel even more out of place for me.

[jorgefilipecosta]

Hi @aaronjorbin, @desrosj, @peterwilsoncc, thank you for all the points raised and preparing a revert. I left some comments on the Trac ticket https://core.trac.wordpress.org/ticket/65012 answering some of the points being discussed here. I think it would be best to continue the conversation there so it's not split across two places.