Skip to content

Fix core/get-site-info language field to always return site locale#11388

Open
Adi-ty wants to merge 1 commit intoWordPress:trunkfrom
Adi-ty:fix/get-site-info-ability-locale
Open

Fix core/get-site-info language field to always return site locale#11388
Adi-ty wants to merge 1 commit intoWordPress:trunkfrom
Adi-ty:fix/get-site-info-ability-locale

Conversation

@Adi-ty
Copy link
Copy Markdown

@Adi-ty Adi-ty commented Mar 29, 2026

This core/get-site-info ability returned the wrong language value in admin context. It used get_bloginfo( language ), which goes through determine_locale() and may resolve to the current user locale in wp-admin. For a site-level ability, this is incorrect because the language field should represent the site locale consistently.

Trac ticket: https://core.trac.wordpress.org/ticket/64977


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

…in admin

Fixes #64977

The ability's language field now uses get_locale() directly to ensure
it always returns the site language locale, not context-aware user locale.
@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props iamadisingh.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant