-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Copy React vendor scripts from Gutenberg, update version number #11359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jsnajdr
wants to merge
1
commit into
WordPress:trunk
Choose a base branch
from
jsnajdr:update/copy-react-from-gutenberg
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+11
−31
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3923,18 +3923,18 @@ public function test_vendor_script_versions_registered_manually( $script, $handl | |
| } | ||
|
|
||
| /* | ||
| * Append '.1' to the version number for React and ReactDOM. | ||
| * Append '-wp' to the version number for React and ReactDOM. | ||
| * | ||
| * This is due to a change in the build to use the UMD version of the | ||
| * This is due to a change in the build to stop using the UMD version of the | ||
| * scripts, requiring a different version number in order to break the | ||
| * caches of some CDNs. | ||
| * | ||
| * This can be removed in the next update to the packages. | ||
| * This can be removed in the next update to the packages (to React 19). | ||
| * | ||
| * See https://core.trac.wordpress.org/ticket/62422 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Worth also adding https://core.trac.wordpress.org/ticket/64958 for context? If I'm reading it correctly, the previous ticket refers to switching to UMD builds, and this PR is switching away. |
||
| */ | ||
| if ( in_array( $handle, array( 'react', 'react-dom' ), true ) ) { | ||
| $package_json[ $script ] .= '.1'; | ||
| if ( in_array( $handle, array( 'react', 'react-dom', 'react-jsx-runtime' ), true ) ) { | ||
| $package_json[ $script ] .= '-wp'; | ||
| } | ||
|
|
||
| $script_query = $wp_scripts->query( $handle, 'registered' ); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And
react-jsx-runtime?