Skip to content

Commit

Permalink
Build/Test: Update assertions in AtomParser_Parse_Test::test_parse_se…
Browse files Browse the repository at this point in the history
…ts_handlers

On some instances of Windows, the assertions seem to find additional nodes. As this test is just about verifying that the handlers get called, not about testing the functionality of the handlers, we can adjust the assertion to look for a minimum number of nodes rather than exact number.

Follow-up to [59062].

Props yogeshbhutkar, hellofromTonya, SergeyBiryukov, coquardcyr, jrf, benniledl, desrosj, jorbin.
Fixes #62110. See #62061.



git-svn-id: https://develop.svn.wordpress.org/trunk@59739 602fd350-edb4-49c9-b593-d223f7449a82
  • Loading branch information
aaronjorbin committed Jan 30, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent 6b41380 commit 439b172
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tests/phpunit/tests/atomlib/AtomParser_Parse_Test.php
Original file line number Diff line number Diff line change
@@ -68,8 +68,8 @@ public function _default( $parser, $data ) {
$this->assertSame( 28, $atom->start_element_call_counter, sprintf( $msg, 'start_element' ) );
$this->assertSame( 28, $atom->end_element_call_counter, sprintf( $msg, 'end_element' ) );
$this->assertSame( 2, $atom->start_ns_call_counter, sprintf( $msg, 'start_ns' ) );
$this->assertSame( 0, $atom->end_ns_call_counter, sprintf( $msg, 'end_ns' ) );
$this->assertSame( 57, $atom->cdata_call_counter, sprintf( $msg, 'cdata' ) );
$this->assertSame( 2, $atom->default_call_counter, sprintf( $msg, '_default' ) );
$this->assertGreaterThanOrEqual( 0, $atom->end_ns_call_counter, sprintf( $msg, 'end_ns' ) );
$this->assertGreaterThanOrEqual( 57, $atom->cdata_call_counter, sprintf( $msg, 'cdata' ) );
$this->assertGreaterThanOrEqual( 2, $atom->default_call_counter, sprintf( $msg, '_default' ) );
}
}

0 comments on commit 439b172

Please sign in to comment.